[Internal] Add transport to handle request routing #16221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankane-msft
requested review from
chlowell,
jhendrixMSFT,
richardpark-msft and
RickWinter
as code owners
seankane-msft
changed the title
richardpark-msft
requested changes
Nov 23, 2021
jhendrixMSFT
pushed a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Jan 12, 2022
* added basic client for routing * using simplifed single client * removing policy code * adding test to ensure routing client works same as original client * adding changelog entry and changing struct name * undoing tables changes * improving test, changing name * updating changelog * setting recordMode variable instead of env var * adding issue number to changelog entries * updating date for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16217
Currently users have to use a custom policy and a custom transport. This replaces the custom policy and makes only a custom transport necessary. The new transport uses uses the internal
recording.ReplaceAuthoritymethod to route requests. In the future this will limit the amount of code needed in each library and remove some of the calls to therecordingmodule.I will go through updating libraries already using the policy and
GetHTTPClientmethod in a future PR